Skip to content

Test using c tag instead of code #3628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Test using c tag instead of code #3628

merged 1 commit into from
Dec 5, 2019

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Dec 5, 2019

@mairaw mairaw requested a review from gewarren December 5, 2019 02:27
@mairaw mairaw self-assigned this Dec 5, 2019
@mairaw mairaw added this to the December 2019 milestone Dec 5, 2019
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change looks good, but I noticed that there are 3 crefs that aren't resolving. It doesn't look like those types/members are on docs?

image

@mairaw
Copy link
Contributor Author

mairaw commented Dec 5, 2019

I don't think they are on docs. These Microsoft.Extensions are auto-generated from /// comments. I just wanted to test that the changes that I made to the source would create the desired effect since a contributor pointed out that there were more cases like this. So before we proceed to fix those, I wanted to make sure it would work to change the tag.

There are still quite a few warnings to go through in the build report since we migrated to SDP, but I'd say this is low-pri at this moment.

@mairaw mairaw merged commit 2b083ad into master Dec 5, 2019
@mairaw mairaw deleted the mairaw-patch-1 branch December 5, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants